Skip to content

fix: button icon layout regressions#5902

Merged
idoshamun merged 1 commit intomainfrom
codex/fix-button-icon-layout
Apr 21, 2026
Merged

fix: button icon layout regressions#5902
idoshamun merged 1 commit intomainfrom
codex/fix-button-icon-layout

Conversation

@idoshamun
Copy link
Copy Markdown
Member

@idoshamun idoshamun commented Apr 21, 2026

What changed

  • limited the translation-safe .btn-label wrapper to text-only button children so dropdown triggers and other mixed-content buttons keep their original layout
  • made button icon spacing use explicit left/right utility classes instead of relying on child order
  • added button regression coverage for icon positioning and mixed-content children

Why

A recent button change kept a stable label wrapper to avoid browser translation issues during loading, but it also wrapped complex button children. Dropdown triggers that render their chevron inside children were then laid out incorrectly, which is why the profile select looked broken.

Impact

Buttons keep the translation fix for plain text labels, while mixed-content buttons like dropdown triggers render correctly again.

Validation

  • pnpm exec eslint src/components/buttons/Button.tsx src/components/buttons/common.ts src/components/buttons/Button.spec.tsx (from packages/shared)
  • node ./scripts/typecheck-strict-changed.js

Preview domain

https://codex-fix-button-icon-layout.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Apr 21, 2026 10:46am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Apr 21, 2026 10:46am

Request Review

@idoshamun idoshamun changed the title [codex] fix button icon layout regressions fix: button icon layout regressions Apr 21, 2026
@idoshamun idoshamun marked this pull request as ready for review April 21, 2026 10:47
@idoshamun idoshamun merged commit fc18ac1 into main Apr 21, 2026
15 checks passed
@idoshamun idoshamun deleted the codex/fix-button-icon-layout branch April 21, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant